This PR updates the HttpClients smoke test to use the new assertion framework introduced in #4141, replacing the old pattern with the fluent assertion API.

Changes Made

Framework Enhancements

• Added missing assertion methods to DependencyAssert:
  • hasData(String) - asserts dependency data (URL)
  • hasType(String) - asserts dependency type
  • hasResultCode(String) - asserts HTTP result code
• Fixed existing bugs in assertion classes:
  • Fixed hasParent(String) in both DependencyAssert and RequestAssert to properly check parent ID instead of incorrectly checking for null

HttpClientTest Migration

• Replaced old assertion pattern using testing.getTelemetry(3) with new testing.waitAndAssertTrace()
• Converted all assertions to use fluent assertion API with TraceAssert, RequestAssert, and DependencyAssert
• Maintained same validation logic for:
  • 1 request with success=true and _MS.ProcessedByMetricExtractors property
  • 3 dependencies (200, 404, 500 status codes) with proper parent-child relationships
  • All HTTP-specific attributes (name, data, type, target, resultCode, success)
• Removed unused imports (assertThat, MapEntry.entry)

Before (Old Pattern)

private static void verify(String successUrlWithQueryString) throws Exception {
  Telemetry telemetry = testing.getTelemetry(3);
  
  assertThat(telemetry.rd.getProperties())
      .containsExactly(entry("_MS.ProcessedByMetricExtractors", "True"));
  assertThat(telemetry.rd.getSuccess()).isTrue();
  
  assertThat(telemetry.rdd1.getName()).isEqualTo("GET /mock/200");
  assertThat(telemetry.rdd1.getData()).isEqualTo(successUrlWithQueryString);
  // ... more individual assertions
}

After (New Framework)

private static void verify(String successUrlWithQueryString) throws Exception {
  testing.waitAndAssertTrace(
      trace ->
          trace
              .hasRequestSatisying(
                  request ->
                      request
                          .hasSuccess(true)
                          .hasProperty("_MS.ProcessedByMetricExtractors", "True")
                          .hasNoParent())
              .hasDependencySatisying(
                  dependency ->
                      dependency
                          .hasName("GET /mock/200")
                          .hasData(successUrlWithQueryString)
                          .hasType("Http")
                          .hasTarget("host.testcontainers.internal:6060")
                          .hasResultCode("200")
                          .hasSuccess(true)
                          .hasProperty("_MS.ProcessedByMetricExtractors", "True")
                          .hasParent(trace.getRequestId(0)))
              // ... more dependency assertions
  );
}

Benefits

• More readable and maintainable test code using fluent assertions
• Better error messages when assertions fail due to the structured approach
• Consistent with other smoke tests that have already been migrated to the new framework
• Type-safe assertions with compile-time checking

The migration maintains full functional equivalence while providing a cleaner, more maintainable test structure that aligns with the project's testing standards.

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.